Wildcard searching #17
Conversation
waybackpack/pack.py
Outdated
| self.parsed_url.netloc, | ||
| path_head | ||
| ) | ||
|
|
||
| filepath = os.path.join(filedir, path_tail) | ||
| filepath = os.path.join(filedir, | ||
| ','.join((path_tail, asset.timestamp))) |
There was a problem hiding this comment.
Most of these change to the path are because I found it more convenient, for my own purposes, to have different versions of the same resource name in the same file. I can make a version that keeps your current, separate directory, behavior.
There was a problem hiding this comment.
Ah, interesting. I'd prefer to keep the current, separate-directory behavior. But I'm curious: What makes the other way more convenient for your purposes?
There was a problem hiding this comment.
p.s., Thanks! This seems to be a really elegant solution.
|
K, this should be good to merge. |
|
Hi @fgregg and apologies for the radio silence. I actually do like this approach! I've been working on a new version that integrates the bulk of your PR (with a few tweaks), but have gotten distracted by other things. Thanks for the nudge! |
|
@jsvine Any updates on this?
Any updates on this? Would you like it implemented in a different way? |
|
Hi @Joey-Einerhand, unfortunately there are no major updates on this. I ran into some operating-system-appeasing issues, got stumped, and haven't fully revisited. |
This PR enables wildcard url fetches from wayback machine.