Add the possibility to set a custom root component tag #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstejada
approved these changes
Oct 16, 2017
| ```xml | ||
| <span class="Typist"> Animate this text. </span> | ||
| ``` | ||
|
|
| @@ -8,6 +8,7 @@ export default class Typist extends Component { | |||
|
|
|||
| static propTypes = { | |||
| children: PropTypes.node, | |||
| component: PropTypes.oneOfType([PropTypes.element, PropTypes.string]), | |||
There was a problem hiding this comment.
this should be oneOfType([PropTypes.func, PropTypes.string]), if we actually want to allow component classes.
However, I'm thinking that for simplicity's sake, we should just take a string without allowing component classes at all. I thing just specifying a dom tag should be sufficient for most use cases.
| @@ -32,6 +32,7 @@ class TypistExample extends React.Component { | |||
| return ( | |||
| <div className="TypistExample"> | |||
| <Typist | |||
| component="div" | |||
There was a problem hiding this comment.
nit: do we really need this here?
| @@ -214,9 +214,10 @@ module.exports = | |||
| var isDone = this.state.isDone; | |||
|
|
|||
| var innerTree = utils.extractTreeWithText(this.props.children, this.state.text); | |||
| var WrapComponent = this.props.component; | |||
There was a problem hiding this comment.
would you mind removing this generated code from the PR? I'll make sure to generate a new dist when I cut a new version.
|
@branchard, just a friendly ping :) I think you need to pull latest from master -- |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will produce: