Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial overhaul to score page #53

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Initial overhaul to score page #53

merged 3 commits into from
Feb 29, 2024

Conversation

josh-collinsworth
Copy link
Contributor

@josh-collinsworth josh-collinsworth commented Feb 28, 2024

TODO: also update the Score shown in the header/nav

CleanShot 2024-02-28 at 17 07 48@2x

image

Copy link
Contributor

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than say "Total score" above the dial, maybe "Quality" or "JSR Score". It will be more screenshot-able with more context

@lucacasonato
Copy link
Member

I changed the name to "JSR Score" and added a description and the package name into the card to make the card easially screenshot-able

image

@lucacasonato lucacasonato requested a review from ry February 29, 2024 07:14
@lucacasonato
Copy link
Member

@josh-collinsworth I am going to land this as is, so I can work on the expanded description for each of the items in the score. Can you do the score in the nav in a follow up?

@lucacasonato lucacasonato added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 09d389b Feb 29, 2024
5 checks passed
@lucacasonato lucacasonato deleted the joco/score branch February 29, 2024 07:24
@josh-collinsworth
Copy link
Contributor Author

Love the changes here. I'll look at the header today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants