Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nitpick docs #209

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Nitpick docs #209

merged 4 commits into from
Mar 6, 2024

Conversation

rojvv
Copy link
Contributor

@rojvv rojvv commented Mar 6, 2024

  • Consistently refer to Node.js as Node.js, not Node.
  • Other minor improvements.

Copy link
Contributor

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistently refer to Node.js as Node.js, not Node.

I mean, if that helps readers. But the name of project is "Node".

@rojvv
Copy link
Contributor Author

rojvv commented Mar 6, 2024

@ry It is referred to as Node.js in their docs, and you already have a number of mentions of it as Node.js. Here’s an example:

compatibility layer. Examples of such tools are, **Node.js**, **Cloudflare

Regardless of which one is right, my goal is to make it consistent. Do you want to switch to Node?

@rojvv rojvv requested a review from ry March 6, 2024 11:07
frontend/docs/badges.md Outdated Show resolved Hide resolved
frontend/docs/badges.md Outdated Show resolved Hide resolved
frontend/docs/badges.md Outdated Show resolved Hide resolved
@rojvv rojvv requested a review from lucacasonato March 6, 2024 13:40
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lucacasonato lucacasonato added this pull request to the merge queue Mar 6, 2024
Merged via the queue into jsr-io:main with commit 7a2c3a6 Mar 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants