Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use provenance in JSR score #163

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

littledivy
Copy link
Member

Closes #84

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@littledivy Do you want this to be an "additional point" or update the maximum total by one?

@littledivy
Copy link
Member Author

I think we update max total by one.

oh i see, i have to bump the MAX_SCORE for that

@lucacasonato
Copy link
Member

You also have to bump it on the JS side

@littledivy
Copy link
Member Author

Can you point me to where that is?

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad - that does not exist anymore. Then, LGTM modulo the docs nit!

frontend/routes/package/score.tsx Outdated Show resolved Hide resolved
@lucacasonato lucacasonato changed the title Use provenance for package score feat: use provenance in JSR score Mar 5, 2024
@lucacasonato lucacasonato added this pull request to the merge queue Mar 5, 2024
Merged via the queue into jsr-io:main with commit d18b21f Mar 5, 2024
6 checks passed
@littledivy littledivy deleted the divy/provenance_score branch March 7, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include provenance attestations in package score
2 participants