Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow inviting to scope via user id #11

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Conversation

crowlKats
Copy link
Collaborator

No description provided.

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use this to get users by email address, which seems bad.

I think the intended feature here was not "invite users that are already on jsr by email", but "invite users not already on jsr, by email". That feature would also need some changes to how invites work.

@crowlKats
Copy link
Collaborator Author

crowlKats commented Feb 28, 2024

no, my intention here was for existing users (which could be expanded to non-existing ones i guess). right now its a pain to invite people: given an email, I have to go search & find their github user name, which sometimes takes more time than it should. also inviting by user ID should also be allowed.

@lucacasonato
Copy link
Member

Well we definitely can't do this. Users that do not have their email set to public on GitHub, now effectively get their email publicized by us - that is not acceptable.

@crowlKats
Copy link
Collaborator Author

not sure I understand. you would need to have the user's email in the first place to invite them, not the other way around

@lucacasonato
Copy link
Member

lucacasonato commented Feb 28, 2024

If you have an email (or you generated many emails), you can check if it's correct or not by submitting it to this API. Because there is no rate limiting, you can do that many times a second (brute forcing the email).

# Conflicts:
#	frontend/routes/@[scope]/(_islands)/ScopeInviteForm.tsx
@crowlKats crowlKats changed the title feat: allow inviting to scope via email feat: allow inviting to scope via user id Mar 4, 2024
api/src/api/types.rs Outdated Show resolved Hide resolved
@crowlKats crowlKats added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit dc64c63 Mar 5, 2024
6 checks passed
@crowlKats crowlKats deleted the scope-invite-email branch March 5, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants