-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow inviting to scope via user id #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use this to get users by email address, which seems bad.
I think the intended feature here was not "invite users that are already on jsr by email", but "invite users not already on jsr, by email". That feature would also need some changes to how invites work.
no, my intention here was for existing users (which could be expanded to non-existing ones i guess). right now its a pain to invite people: given an email, I have to go search & find their github user name, which sometimes takes more time than it should. also inviting by user ID should also be allowed. |
Well we definitely can't do this. Users that do not have their email set to public on GitHub, now effectively get their email publicized by us - that is not acceptable. |
not sure I understand. you would need to have the user's email in the first place to invite them, not the other way around |
If you have an email (or you generated many emails), you can check if it's correct or not by submitting it to this API. Because there is no rate limiting, you can do that many times a second (brute forcing the email). |
# Conflicts: # frontend/routes/@[scope]/(_islands)/ScopeInviteForm.tsx
No description provided.