Add an option that force the focus to be inside the lity box on tab key (fix a flaw) #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user press tab to navigate in the page It was possible indeed to escape the box (at least on FF) by pressing tab key several times : after going through all the focusable elements of the box, the focus goes on browser navigation buttons (previous page, address bar field) before re-entering the page on the first focusable element of the page, which is not in the lity box any more As this is happening without a shift key the handleTabKey() doesn't fix it and then you have to go through all the page to reenter the box. As I'm not sure if this is the expected behavior, I added an option to activate the hard forced focus in the box, but maybe this is not needed and could be the default behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible indeed to escape the box (at least on FF) by pressing tab key several times : after going through all the focusable elements of the box, the focus goes on browser navigation buttons (previous page, address bar field) before re-entering the page on the first focusable element of the page, which is not in the lity box any more
As this is happening without a shift key the handleTabKey() doesn't fix it and then you have to go through all the page to reenter the box.
As I'm not sure if this is the expected behavior, I added an option to activate the hard forced focus in the box, but maybe this is not needed and could be the default behavior?