build: Node.js 19+ #53
Open
+93
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wesleytodd Shouldn't this package also include tests for Windows and maybe for macOS? |
bjohansebas
force-pushed
the
node23
branch
2 times, most recently
from
a195e96 to
6d716bd
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
wesleytodd
approved these changes
Jan 15, 2025
|
I see a problem that could result in a resource drain, and that is when a test fails, Mocha is not exiting the program, which causes the CI to keep running until manually canceled or a timeout occurs from GitHub. I noticed this while debugging to bring the CI for Node.js 9 |
|
We can adjust the timeout, but frankly I am not super concerned about this. I would rather see us just spend time improving the tests and only worry about this if it starts blocking work. |
UlisesGascon
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are added for Node.js 19+, and the CI for compression is copied.