optional libsodium #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshawl
commented
Feb 19, 2024
lib/minisign/nacl.rb
Outdated
| module Minisign | ||
| # A module that invokes RbNaCl with user-focused actionable error messages. | ||
| module NaCl | ||
| def self.safely |
There was a problem hiding this comment.
is this really safe if it raises? maybe .with_libsodium would be more meaningful?
There was a problem hiding this comment.
or instead of a block? something like:
module Blake2b
def self.digest(*args)
assert_libodium_dependency_met!
RbNaCl::Hash::Blake2b.digest(*args)
end
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
No libsodium? No problem! You can still install this gem and verify signatures without libsodium if you please.
Checklist: