Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sementic div > {nodeText} to div > p > {nodeText} #1688

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

A-312
Copy link

@A-312 A-312 commented Sep 11, 2019

Q A
Bug fix? yes
New feature? no
Breaking change? no
Deprecations? no
Tests added? no
Fixed issues -

Improve sementic div > {nodeText} to div > p > {nodeText}. According to: https://stackoverflow.com/a/2226574/2226755 elements should be : div > p > {nodeText}

This make no visual change is only semantic, you can check this : before / after

Q/A

Check the doc page, you should see no difference in the render.

@A-312
Copy link
Author

A-312 commented May 2, 2020

When we use md plugin like this : "plugins": [ "node_modules/jsdoc/plugins/markdown" ],, we get double p like this : div > p > p > {nodeText}, we should fix the semantic when md plugin are not called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant