-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modeling): preserve color for offset and extrude #1275
Conversation
16e43a3
to
a51b299
Compare
a51b299
to
b117448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This a move in right direction. Colors from boolean ops were removed for perf gain, but it is possible we will be able to make keeping colors optional in the future for booleans.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@platypii nice set of changes, and very nice improvements for the user experience.
i just have a bunch of nits. sorry.
@z3dev I just pushed some more changes which I hope will address your concerns:
Let me know what you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@platypii thanks for hanging in there. Sometimes it take time to sort out differences in opinion.
The changes are all good now, with improvements everywhere.
This PR preserves the color attribute when applying operations like
offset
andextrude
andproject
.This seems like a clear improvement for users of JSCAD. If you have a 2D object with color like on the left, would you expect extrusion to preserve the color? Or lose it?
preserve-color.js
If someone really want no color, it's easy to remove using
colorize
. But if you want to preserve color of sub-components through an operation... there's really no good way to do it without this change.All Submissions: