Hinge Constraints #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… axis conversion utility to convert models to +Z Forward coordinate system
|
@jsantell can you please review this MR. I'm working on a project and it will be useful to have hinge constrains on our characters with IK systems. |
|
@jsantell anything is needed here? |
|
Hello! A few more things to make it possible to merge:
Sorry for the slow response! and great work 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jsantell - so as I mentioned in #3 , here is an implementation of hinge constraints along with an example of how to use them.
Currently the usage is very similar to the
IKBallConstraint-- theIKHingeConstraintaccepts a maximum angle as a parameter, and the axis of rotation is determined by the starting orientations of the bones.Few things on the todo list are adding a minimum angle parameter, as well as another parameter for flipping the rotation axis.
I've tested it successfully with 3 models -- looking forward to your thoughts on the implementation :)