Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begrudgingly, change Twitter references to X #1884

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Begrudgingly, change Twitter references to X #1884

merged 1 commit into from
Apr 24, 2024

Conversation

maebert
Copy link
Contributor

@maebert maebert commented Apr 23, 2024 •
edited
Loading

Small fix: Change the twitter icon on the Docs landing page to X, and change the verbiage accordingly

image

becomes...

image

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

@maebert
Begrudgingly, change Twitter references to X
8ac28b7 
Small fix: Change the twitter icon on the Docs landing page to X, and change the verbiage accordingly
micahellison
micahellison approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @maebert. Love the PR title.

@micahellison micahellison merged commit 0aefdb3 into jrnl-org:develop Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maebert @micahellison