Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching RadialSolver Backend to work with Newest CyRK / Additional cythonization #66

Merged
merged 55 commits into from
Jan 3, 2025
Merged

Switching RadialSolver Backend to work with Newest CyRK / Additional cythonization #66

merged 55 commits into from
Jan 3, 2025

Conversation

jrenaud90
Copy link
Owner

@jrenaud90 jrenaud90 commented Jan 3, 2025 •
edited
Loading

  • Major changes of RadialSolver back end to work with newest version of CyRK
    • This results in a much more accurate, faster, and stable RadialSolver
  • Major changes to RadialSolver results
  • Different argument structure
  • New Equation of State backend for the RadialSolver
  • Cythonized propagation matrix method to use with RadialSolver
  • Deprecated old TidalPy radial_solver module
  • Many new tests, documentation, and fixes

Solves:

Partially Solves:

@jrenaud90
Merge pull request #64 from jrenaud90/dev0.6.0
3127f81 
Merge Main
@jrenaud90
Initial pass at shooting method and solver function
ac77f83
@jrenaud90
Removed old radial_solver
927b118
@jrenaud90
fixes
d0b2ef6
@jrenaud90
fixing
e1ef2c8
@jrenaud90
Implementing new RadialSolver Backend based on CyRK v0.10
bbf651e
@jrenaud90
Fixed issue where python could not read TidalPy.constants
6509f30
@jrenaud90
New equation of state solution; various fixes and debugging
54f7b76
@jrenaud90
Updated radial solution python wrapper class
c6ebbf2
@jrenaud90
Finished propagating changes through RadialSolver and EOSSolver
d141614
@jrenaud90
working on starting radius formula
f2a86b1
@jrenaud90
Implemented starting radius algorithm in shooting method
01c00b9
@jrenaud90
Working on compatibility w/ CyRK 0.11.3
3ab7c29
@jrenaud90
EOS working with CyRK 0.11.3
282c575
@jrenaud90
1 layer model is now working
cb9854c
@jrenaud90
Working for multiple layers; non-dim not working yet (and maybe TS72?)
2660a77
@jrenaud90
Fixed issue in non-dim
465ba48
@jrenaud90
fixed typing error. may have helped with stability?
9319298
@jrenaud90
Identified floating point errors
7f1628f
@jrenaud90
Added in hooks to change EOS method for the future
55b4987
@jrenaud90
Fixed issues with non-dim
cfb1cdb
@jrenaud90
Added tracker for integration steps required in RadialSolver
c8d1771
@jrenaud90
Working with CyRK 0.12.1
f48a687
@jrenaud90
Older RadialSolver tests now passing
513e374
@jrenaud90
Earth benchmarks not working
ec7bf9c
@jrenaud90
Fixed issue with love number output; Fixed rheology class prefix name
10273f1
@jrenaud90
Fixed issue with EOS upper radius; Reworked how radialsover reads in …
47f53ef 
…radius arrays; more sanity checks.
@jrenaud90
Added new helper function for preparing constant layered planets for RS
585dcc2
@jrenaud90
Fixed issue where starting radius was in a layer other than 0th
0672f13
@jrenaud90
changed arg name
f5145e3
@jrenaud90
Fixing tests
f0171d2
@jrenaud90
Added tests for RadialSolver.helpers
594e493
@jrenaud90
Switched the rs input helper function to output named tuples
c8d6fde
@jrenaud90
Moved around notes
9cd4f18
@jrenaud90
Fixed bug in eos solution collapse
3578ba7
@jrenaud90
Updated radial solver tests (all RS tests passing)
b701520
@jrenaud90
Fixed non-dim test; added RS to top level import
9376bc4
@jrenaud90
Working on radial sensativity functions
74eaad2
@jrenaud90
Working propagation matrix method
8f05b56
@jrenaud90
Updated Changes
5bf59bb
@jrenaud90
Working on radial sensativity
d5ffba3
@jrenaud90
Cythonized radial heating (based on sensitivity)
c7c2fd6
@jrenaud90
Removed dev notebooks
150ed5a
@jrenaud90
Passing tests (windows)
bc74123
@jrenaud90
Fixed issue caused by new burnman version; fixed issue with long vs. …
a3775f6 
…ints
@jrenaud90
Removed parallel from njit funcs; fixed bad import
f7eb929
@jrenaud90
Converted all C files to C++
1e49a84
@jrenaud90
Fixed issue in radial heating func; added buffer types to ndarrays
017c9ef
@jrenaud90
Updated Github actions
69b3beb
@jrenaud90
Missing cython header; changed uchar to int
87340e9
@jrenaud90
Added more tests and docstrings
1b6b99e
@jrenaud90
Added new RS helper to work with data arrays
5fb6dab
@jrenaud90
Debugging odd ARM macos error
ba4d5b1
@jrenaud90
Debugging macos issue; removed parallel bit
5af1110
@jrenaud90
Seeing if xdist was the problem
0629f45
@jrenaud90 jrenaud90 merged commit 0bf073c into dev0.6.0 Jan 3, 2025
32 checks passed
@jrenaud90 jrenaud90 deleted the cythonizing-propagation-matrix branch January 3, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrenaud90