fix VScode warnings

check/blocklist.go

@@ -50,6 +50,5 @@ var getBlockListFile = func() (*os.File, error) {
 		return nil, newCheckError(err)
 	}
 
-	f, err := os.Open(file)
-	return f, nil
+	return os.Open(file)
 }

check/check_test.go

@@ -33,7 +33,7 @@ func TestNonEmpty(t *testing.T) {
 	}
 	for _, test := range tests {
 		if got := nonEmpty(test.strings...); !equal(got, test.want) {
-
+			t.Errorf("nonEmpty(%v) = %v, want %v", test.strings, got, test.want)
 		}
 	}
 }

check/firehol.go

@@ -9,10 +9,6 @@ import (
 	"github.com/jreisinger/checkip"
 )
 
-type firehol struct {
-	blacklisted bool
-}
-
 // Firehol checks whether the ipaddr is found on blacklist
 // https://iplists.firehol.org/?ipset=firehol_level1.
 func Firehol(ipaddr net.IP) (checkip.Result, error) {

check/testhelpers.go

@@ -1,9 +1,9 @@
 package check
 
 import (
-	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
+	"os"
 	"path/filepath"
 	"testing"
 
@@ -12,7 +12,7 @@ import (
 
 // loadResponse loads named file form testdata directory.
 func loadResponse(t *testing.T, name string) []byte {
-	b, err := ioutil.ReadFile(filepath.Join("testdata", name))
+	b, err := os.ReadFile(filepath.Join("testdata", name))
 	require.NoError(t, err)
 	return b
 }

check/tls.go

@@ -105,18 +105,13 @@ func oldTlsVersion(tlsVersion uint16) bool {
 }
 
 func expiredCert(expiryDate time.Time) bool {
-	if expiryDate.Before(time.Now()) {
-		return true
-	}
-	return false
+	return expiryDate.Before(time.Now())
 }
 
 func tlsFormat(tlsVersion uint16) string {
 	switch tlsVersion {
 	case 0:
 		return ""
-	case tls.VersionSSL30:
-		return "SSLv3"
 	case tls.VersionTLS10:
 		return "TLS 1.0"
 	case tls.VersionTLS11: