-
Notifications
You must be signed in to change notification settings - Fork 12
Start initial base #2
base: main
Are you sure you want to change the base?
Conversation
Hi @raphamorim, About CLA, check your commit vs. signed name: "Raphael H. Amorim" vs "Raphael Amorim" Details here. @arthurvr has a good idea. We could break this work in several different PRs. Perhaps for the first PR, let's try getting Home and one of the API Entries complete. Then, the next PRs are going to be more straightforward implementations extending your initial work. What do you think? Thanks so far! |
Yeah, I realized the problem later. But I was not able to change the name. I agree about implementation. I will finish the Core API. Then we validate this PR to proceed to a next PR. |
@raphamorim, reviewing your change is o my TODO... |
:) |
@@ -1,4 +1,5 @@ | |||
<categories> | |||
<category name="Uncategorized" slug="uncategorized"/> | |||
<category name="Uncategorized" slug="uncategorized"></category> | |||
<category name="Configuration and Utilities" slug="config"></category> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's up to @rxaviers, but shouldn't there be two categories here: Configuration
and Utilities
? Then it's also perfectly possible to add two categories on one article.
Also, I know it's nitpicky, but could you please fix the indentation in all these files? You used spaces while we use tabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the identation I'll fix. Sorry about that.
Configuration
and Utilities
'cause is the standart for others jQuery docs, similar case is qUnit docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @jzaefferer and @scottgonzalez for their input about the naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raphamorim, which content are you going to be put into Configuration and Utilities
? I think it will be clear to figure the naming after knowing that first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be for initialization and additional methods. But I have no problems as changing the name, just follow the QUnit model. We can change here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuration and Utilities 'cause is the standart for others jQuery docs, similar case is qUnit docs.
Definitely not a standard just because it exists in a single site. If anything, the standard would be for separate categories as other projects have a Utilities category. I'd actually say that QUnit should split their category in two, since it's almost exclusively utilities already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. So in this case what would be the category name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything related to configuration would be in Configuration, and utility methods would be in Utilities. Though I think you're best bet is to make a list of what will be documented, then create categories based on the content.
Yeap,
Yeap. |
]]></code> | ||
</example> | ||
<category slug="config"/> | ||
</entry> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it concerns me too much having to maintain documentation content in XML format.
@scottgonzalez can this be generated automatically from markdown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like it eighter. I don't really think anyone likes it, but it's easy to get used to. Scott knows these things way better than I, but I believe things like categories and signatures are difficult in markdown (at least using the current grunt-jquery-content setup). Personally I find markdown in general difficult to keep things consistent and structured enough for API docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. It's all XML. As @arthurvr mentions, this is a necessary evil since API docs are highly structured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx
@rxaviers so I proceed? |
What do you think guys? Can I proceed?
Reference: #1