Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup #2

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Minor cleanup #2

merged 4 commits into from
Feb 7, 2024

Conversation

amisevsk
Copy link
Contributor

@amisevsk amisevsk commented Feb 7, 2024

  • Clean up some small typos and minor errors (e.g. ignoring returned errors)
  • Go format everything since my editor is changing files on save (auto format)
  • Add workflow to check files are formatted, go.mod is tidy, and project builds.

@amisevsk amisevsk requested a review from gorkem February 7, 2024 15:55
gorkem
gorkem approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It can also run the tests, yes we have one :) Not a stopper we can add it later

@amisevsk amisevsk merged commit 0cecbd4 into main Feb 7, 2024
1 check passed
@amisevsk amisevsk deleted the minor-cleanup branch February 7, 2024 16:04
@Jwilliamsr Jwilliamsr mentioned this pull request May 10, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorkem gorkem gorkem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amisevsk @gorkem