Use SQLAlchemy defaults in fields #503
Open
+59
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #491 |
|
Sorry, @hasansezertasan, any updates on this PR? |
It's OK. I was the one who volunteered but I couldn't get my hands free for this. I'll work on it when I get a chance. |
jowilf
reviewed
Mar 6, 2024
starlette_admin/fields.py
Outdated
| @@ -74,6 +75,7 @@ class BaseField: | |||
| id: str = "" | |||
| search_builder_type: Optional[str] = "default" | |||
| required: Optional[bool] = False | |||
| default: str = "" | |||
There was a problem hiding this comment.
Suggested change
| default: str = "" | |
| default: Optional[Any] = None |
|
Thank you, @geoolekom, for submitting this pull request. Would you be interested in implementing it for other backends as well? |
geoolekom
force-pushed
the
feature/use-sqla-defaults
branch
from
f17d460
to
0c1ad9d
Compare
Unfortunately, for now I don't have much time to implement other backends in this PR. Perhaps later, in a separate pull request. For now, I fixed failed CI checks for SQLA backend. Could you trigger the pipeline again? |
geoolekom
force-pushed
the
feature/use-sqla-defaults
branch
from
ca3699e
to
a0da93d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, if a SQLA Column has a default value, it is used in the admin panel. If it is a scalar, then the value is used directly. If it is a function or SQL expression, the extra help text is displayed.