권범준 - 렌더링 최적화 #26
Open
권범준 - 렌더링 최적화 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua1988
reviewed
Feb 23, 2018
| <html> | ||
| <head> | ||
| <meta name="viewport" content="width=device-width"> | ||
| <link rel="prefetch" href="photo.png"> |
There was a problem hiding this comment.
@Lyuesia - 범준님 prefetch를 잘 적용하셨네요!
joshua1988
reviewed
Feb 23, 2018
| <head> | ||
| <meta name="viewport" content="width=device-width"> | ||
| <link rel="prefetch" href="photo.png"> | ||
| <link href="style.css" rel="stylesheet"> |
There was a problem hiding this comment.
@Lyuesia - 최적화의 관점에서 외부 CSS 파일 로딩 대신에 인라인 스타일이나 <style>로 빼주셔도 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.