백성훈 - 답변 제출 #22
Open
백성훈 - 답변 제출 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lutece
commented
Sep 23, 2017
Lutece
commented
joshua1988
reviewed
Sep 26, 2017
| <link href="print.css" rel="stylesheet" media="print"> | ||
|
|
||
| <!-- prefetch를 이용해 리소스를 먼저 다운받음 - 라이브러리 활용 --> | ||
| <link href="photo.png" rel="prefetch"> |
There was a problem hiding this comment.
@Lutece - 성훈님, 이미지에 prefetch를 넣어주신 것도 매우 좋은 튜닝방법이네요!
joshua1988
reviewed
Sep 26, 2017
| Hello <span>Fast Campus WAP Camp</span> students! | ||
| </p> | ||
|
|
||
| <div><img src="photo.png" width="800px" height="800px"></div> |
There was a problem hiding this comment.
이미지 크기 파악 후 태그 사이즈까지 지정해주신 것 매우 훌륭합니다!
joshua1988
reviewed
Sep 26, 2017
| DOM Rendering과 관련이 없다 하더라도 요청이 발생하면 멈추기 때문에.. | ||
|
|
||
| app.js = 네트워크 요청이기 떄문에 Dom Redering과 관련이 없어도 async 사용 | ||
| ga-analytics는 태그 내에 async가 적용되는 건 태그 속성으로 async를 붙이지 않아도 된다. |
There was a problem hiding this comment.
좋은 분석입니다. 그리고 참고로, ga 같은 것들은 공식 사이트에서 가이드 해준 위치를 그대로 따르시는게 좋아요 :)
따라서 바로 밑에 ga를 위치 시키는게 좋을 겁니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.