수업시간_임송이 #17
Open
수업시간_임송이 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua1988
reviewed
Sep 26, 2017
| Hello <span style="color: blue;">Fast Campus WAP Camp</span> students! | ||
| </p> | ||
| <div><img src="photo.png"></div> | ||
| <script src="app.js"></script> |
There was a problem hiding this comment.
@ssongalice - 송이님, 인라인 스타일 시트와 미디어 쿼리 적용으로 HTTP 요청 수를 잘 최소화 시키셨어요. <script> 태그로 로딩하는 자바스크립트의 내용이 화면의 초기 렌더링과 관계가 없을 경우 async나 deferred 옵션을 써주시면, 여기서는 미세한 차이지만 향후에는 더 빠르게 렌더링 하는 효과를 얻으실 수 있을겁니다. 고생 많이하셨어요 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.