서환주 quiz3 최적화작업 #16
Open
서환주 quiz3 최적화작업 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua1988
reviewed
Sep 26, 2017
| } | ||
| </style> | ||
| <script src="ga-analytics.js" async></script> | ||
| <script src="app.js" async></script> |
There was a problem hiding this comment.
환주님, 인라인 스타일로 HTTP 요청을 최소화 하시고, script에 async를 잘 적용하셨습니다. 다만 <script>가 안에 위치하면 안되는데, 이점에 대해서 한번 저희가 수업시간에 살펴봤던 내용들(브라우저 동작과정 최적화 참고) 하셔서 다시 한번 정정해보시길 추천드려요! 고생하셨습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.