박경란 - 렌더링 최적화 #14
Open
박경란 - 렌더링 최적화 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua1988
reviewed
Sep 26, 2017
| <meta name="viewport" content="width=device-width"> | ||
| <!--link href="style.css" rel="stylesheet" --> | ||
| <link href="print.css" rel="stylesheet" media="print"> | ||
| <script src="ga-analytics.js" async></script> |
There was a problem hiding this comment.
@kirtimukha - 경란님, HTTP 요청을 최소화 하기 위해 외부 StyleSheet를 사용하지 않고, 인라인 스크립트로 대체해주신 점은 훌륭합니다. 다만, <script> 태그를 안에 넣으시는 경우, 저희가 배웠던 브라우저 렌더링 과정에 방해가 됩니다.
따라서, 태그 위에 <script> 를 위치시켜 주시고, google analytics 같은 경우에는 원래 규칙이 바로 밑이니 그 점 알고 계시면 좋을 것 같아요. 고생하셨습니다..!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.