-
Notifications
You must be signed in to change notification settings - Fork 80
Remove duplicates in final list #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR addresses joshmedeski#156 and removes duplicates based on the Path entries. Performance time is linear wrt number of entries.
|
Also added a flag to list (--hide-duplicates / -d) to control the removal |
joshmedeski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, right to the point. This is how I would have reimplemented it, thanks!
|
Hang on before merging - I'd like to see if there's a way to make it default on in sesh.toml rather than having to litter -d all over the place. |
|
I don't recommend that @szinn I'd like people to opt-into it for now, in the future we could add something to the config file to allow users to opt-into it always. |
|
But I'm happy with the feature as-is today. We can add the config option as a future optimization. |
|
No way to do it since doesn't appear to allow options yet - merge away! Let me know if there's other tweaks elsewhere! |
Should this now be available? (I've installed via homebrew.) The flag doesn't appear to work and I don't see it mentioned in the notes for any of the releases since this was merged. Edit 1: On closer inspection, it does work in the command line (sorry about not noticing that). The use case that doesn't appear to work is adding the flag to the Is there a way to use this flag as part of the tmux keybinding? (Apologies if this is just user error.) Edit 2: Apologies! This was totally user error. I'd added the flag to the second |
|
@ooloth glad you got it working. I intentionally left it out of the README examples and you have to manually opt-in to it yourself. |
This PR addresses #156 and removes duplicates based on the Path entries.
Performance time is linear wrt number of entries.