Use the correct signature for ConnectionFactory.newConnection. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HaConnectionFactory is overriding and calling newConnection(Address[] addrs), which is not the root method in the super class and is causing incorrect behavior.
In the case of the override, it requires that client implementations call newConnection with addrs, and it doesn't support the default value provided by the ConnectionFactory. In the second case (in newTargetConnection), the superclass implementation calls the overridden method in HaConnectionFactory, which is causing multiple shutdown listeners to be created on the first reconnect and multiple connections on the second reconnect.