chore(ci): remove jsx-short-circuit-conditionals (bigcommerce#891)

jorgemoya · Jun 24, 2022 · ea91ca2 · ea91ca2
1 parent d2b7f0e
commit ea91ca2
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 5 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -25,7 +25,6 @@ module.exports = {
     {
       files: ['**/*.ts', '**/*.tsx', '**/*.js'],
       rules: {
-        '@bigcommerce/jsx-short-circuit-conditionals': 'off',
         '@typescript-eslint/naming-convention': 'off',
         '@typescript-eslint/no-unsafe-return': 'off',
         '@typescript-eslint/no-unsafe-argument': 'off',

diff --git a/packages/big-design/src/components/List/List.tsx b/packages/big-design/src/components/List/List.tsx
@@ -168,7 +168,7 @@ const StyleableList = typedMemo(
         return (
           <>
             {group.separated && <ListGroupSeparator />}
-            {group.label && <ListGroupHeader>{group.label}</ListGroupHeader>}
+            {Boolean(group.label) && <ListGroupHeader>{group.label}</ListGroupHeader>}
             {isItemGroup(group) && renderItems(group.items)}
             {isOptionGroup(group) && renderItems(group.options)}
           </>

diff --git a/packages/big-design/src/components/Panel/Panel.tsx b/packages/big-design/src/components/Panel/Panel.tsx
@@ -37,7 +37,7 @@ export const RawPanel: React.FC<PanelProps & PrivateProps> = memo(({ forwardedRe
 
     return (
       <Flex flexDirection="row">
-        {header && <StyledH2 id={headerId}>{header}</StyledH2>}
+        {Boolean(header) && <StyledH2 id={headerId}>{header}</StyledH2>}
         {action && <Button {...action}>{action.text}</Button>}
       </Flex>
     );

diff --git a/packages/docs/components/ColorCards/ColorCard.tsx b/packages/docs/components/ColorCards/ColorCard.tsx
@@ -56,7 +56,7 @@ const ColorCard: React.FC<ColorCardProps> = ({ colorCard }) => {
       {description && (
         <Small color={colorCard.textColor} margin="small">
           {description.text}{' '}
-          {description.href && (
+          {Boolean(description.href) && (
             <Link href={description.href} target="_blank">
               <Small color="inherit">Read more</Small>
             </Link>

diff --git a/packages/docs/pages/_app.tsx b/packages/docs/pages/_app.tsx
@@ -71,7 +71,7 @@ const App = ({ Component, pageProps }) => {
           }
         `}
       </style>
-      {isProd && GTM_ID && (
+      {Boolean(isProd && GTM_ID) && (
         <>
           <Script
             src={`https://www.googletagmanager.com/gtm.js?id=${GTM_ID}`}