Skip to content

Use QueryMonitorInterface instead of hard-coded DebugMonitor class #45579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 5.3-dev
Choose a base branch
from

Conversation

AlterBrains
Copy link
Contributor

Summary of Changes

Allow debug plugin to use instance of QueryMonitorInterface in query collector.

Currently, it's hard-coded to instance of DebugMonitor (which is a final class for some reason). Hence, we can't use custom monitors with debug plugin enabled.

Testing Instructions

Apply patch. Enable debug in global configuration and debug plugin.

Actual result BEFORE applying this Pull Request

See debug.

Expected result AFTER applying this Pull Request

See same debug, nothing is changed.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@ceford
Copy link
Contributor

ceford commented Jun 10, 2025

I have tested this item ✅ successfully on 1f1117f

No change in Database section of debug bar on applying this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45579.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants