[5.3] Optimize load of smart search plugins language #45345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Currently,
\Joomla\Component\Finder\Administrator\Helper\LanguageHelper::loadPluginLanguage()
uses a database query to get list of available finder plugins and next loads their language files.This database query is useless because we can use native
PluginHelper::getPlugin('finder')
method which provides additional benefit (no extra database query is executed).Additionally, the language load should be performed using system-wide
$extension
key likeplg_finder_content
to prevent duplicate language file load.This method is called in all com_finder views plus mod_finder display, we can remove extra database and prevent duplicate language load.
Testing Instructions
Apply patch. Test smart search views in frontend, check smart search module display.
Actual result BEFORE applying this Pull Request
See extra database query like
Expected result AFTER applying this Pull Request
All views and module work as usual, no extra database query
Link to documentations