Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user.js - alternative Administrator Login without GUI #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LadySolveig
Copy link
Contributor

We do not need to load the GUI for the backend login - this command can be used alternatively if not the login method directly should be checked.

We do not need to load the GUI for the backend login - this command can be used alternatively if not the login method directly should be checked.
@laoneo
Copy link
Contributor

laoneo commented Jun 19, 2024

What is the intention behind this pr? For the CMS tests we use session snapshots, so the slow login is only used once. For me it would be too confusing to have two different login ways. I would then rather replace the existing one with this one and move the login tests actually to the CMS repo.

@LadySolveig
Copy link
Contributor Author

I personally have been using this snippet for my extension tests for a few months now. I don't want to test the basic functionality of Joomla, that is done in the CMS repo itself.
I just wanted to make it available in case it is also interesting for the package for other extension developers.

@laoneo
Copy link
Contributor

laoneo commented Jun 19, 2024

I totally agree that the login code should be ported here. What do you think about joomla/joomla-cms#43673? And then I would replace the doAdministratorLogin with your code and not add a new function.

@LadySolveig
Copy link
Contributor Author

Could also be a nice solution, as we have with your PR independent tests in the CMS itself especially for the login. I haven't even thought that far ahead yet 👍🏼

@laoneo
Copy link
Contributor

laoneo commented Jun 19, 2024

Can you replace then the existing function, instead of adding a new one?

@LadySolveig
Copy link
Contributor Author

I will test with 5.1 and 5.2 today and will be happy to make the desired change if all goes well. 👍🏼

@laoneo
Copy link
Contributor

laoneo commented Jun 24, 2024

Thanks!

@muhme
Copy link
Contributor

muhme commented Jun 24, 2024

@LadySolveig If you can, could you please also test with 4.4-dev and 6.0-dev? joomla-cxpress supports all active Joomla branches. Or give me a short ping and I can test the four branches.

@LadySolveig
Copy link
Contributor Author

As I mentioned in the other PR it is not possible to run the tests with 4.4 with a new version of this package cause of this modification b37bbf5 #11 and the corresponding change in cms for 5.1 onwards.
Otherwise it would first have to be tested what would have to be changed for the installation on 4.4 so that it works on both versions.

@muhme
Copy link
Contributor

muhme commented Jun 25, 2024

Language selection should not be the problem as shown in #13. We are on the way to have only one joomla-cypress version used in all active Joomla branches. With using actual joomla-cypress in 4.4-dev the Cypress.Commands.overwrite needs to be deleted and there are still four remaining places to be checked ...

My question is, will this new login with token work on all active Joomla releases dev-4.4 ... dev-6.0?

@laoneo
Copy link
Contributor

laoneo commented Jun 25, 2024

It is also possible to select by the value or index, so we are independent by the language name. Perhaps it is an alternative to selecting by language string.

@laoneo
Copy link
Contributor

laoneo commented Oct 20, 2024

@LadySolveig do you plan to implement the changes? Because I want to create soon a new release here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants