Skip to content

Bump rustls from 0.22.1 to 0.23.18 #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TCeason
Copy link

@TCeason TCeason commented Nov 25, 2024

Suggest bump, in databend ci:

cargo audit --db ./target/advisory-db
==> build-tool using image runner/build-tool:dev-nightly-2024-07-02
Fetching advisory database from [https://github.com/RustSec/advisory-db.git](https://github.com/RustSec/advisory-db.git%60)
Loaded 688 security advisories (from ./target/advisory-db)
Updating crates.io index
Scanning Cargo.lock for vulnerabilities (1349 crate dependencies)
Crate: rustls
Version: 0.22.4
Title: rustls network-reachable panic in Acceptor::accept
Date: 2024-11-22
ID: RUSTSEC-2024-0399
URL: https://rustsec.org/advisories/RUSTSEC-2024-0399
Solution: Upgrade to >=0.23.18
Dependency tree:
rustls 0.22.4
├── tokio-rustls 0.25.0
│ └── opensrv-mysql 0.7.0
│ └── databend-query 0.1.0
│ ├── databend-enterprise-query 0.1.0
│ │ └── databend-binaries 0.1.0
│ └── databend-binaries 0.1.0
├── msql-srv 0.11.0
│ └── databend-sqllogictests 0.1.0
└── databend-query 0.1.0

@TCeason
Copy link
Author

TCeason commented Nov 25, 2024

Hi @jonhoo Please review this pr.

@mjgarton
Copy link
Contributor

mjgarton commented Dec 3, 2024

I personally welcome this change, but I think this is a breaking change (for callers that also interact directly with rustls), so probably the msql-srv version in Cargo.toml needs bumping?

@TCeason
Copy link
Author

TCeason commented Dec 3, 2024

I personally welcome this change, but I think this is a breaking change (for callers that also interact directly with rustls), so probably the msql-srv version in Cargo.toml needs bumping?

I see tokio-rustls it use ring feature.

@jonhoo
Copy link
Owner

jonhoo commented Dec 15, 2024

Since I don't use this crate any more myself, I'm ending up with very little time to actually devote to its upkeep. If either of you are actively using it, would you be interested in stepping up to maintaining it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants