Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @EnableDiscoveryClient annotation #18

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

vanam
Copy link
Contributor

@vanam vanam commented Jul 13, 2024

According to the Official Spring Cloud docs, the @EnableDiscoveryClient annotation is not required anymore:

@EnableDiscoveryClient is no longer required. You can put a DiscoveryClient implementation on the classpath to cause the Spring Boot application to register with the service discovery server."

See: https://docs.spring.io/spring-cloud-commons/reference/4.1/spring-cloud-commons/common-abstractions.html#discovery-client

@vanam vanam mentioned this pull request Jul 13, 2024
According to the Official Spring Cloud docs, it is not required anymore:
"@EnableDiscoveryClient is no longer required. You can put a
DiscoveryClient implementation on the classpath to cause the Spring Boot
application to register with the service discovery server."

See: https://docs.spring.io/spring-cloud-commons/reference/4.1/spring-cloud-commons/common-abstractions.html#discovery-client

Closes jonatan-ivanovgh-18
@jonatan-ivanov jonatan-ivanov force-pushed the enable-discovery-client branch from 27ed5f2 to 3329b60 Compare July 15, 2024 23:50
@jonatan-ivanov jonatan-ivanov changed the title Let autoconfiguration handle @EnableDiscoveryClient. Remove @EnableDiscoveryClient annotation Jul 15, 2024
@jonatan-ivanov jonatan-ivanov added the enhancement New feature or request label Jul 15, 2024
@jonatan-ivanov jonatan-ivanov merged commit 049eab2 into jonatan-ivanov:main Jul 15, 2024
1 check passed
@jonatan-ivanov
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants