Skip to content

Commit

Permalink
fix(deps): Force nikic/php-parser >= 4.7 because of a strange bug (#129)
Browse files Browse the repository at this point in the history
Without this patch, we get the following error:

```
SYMFONY_REQUIRE=5.4 composer up --prefer-lowest && vendor/bin/simple-phpunit tests/Jane/JaneTest.php
```

```
Testing JoliCode\Elastically\Tests\Jane\JaneTest
Jane (JoliCode\Elastically\Tests\Jane\Jane)
 ✘ Create index and search with jane object
   ┐
   ├ Undefined array key 265
   │
   ╵ /home/gregoire/dev/github.com/jolicode/elastically/vendor/nikic/php-parser/lib/PhpParser/Lexer.php:255
   ╵ /home/gregoire/dev/github.com/jolicode/elastically/vendor/nikic/php-parser/lib/PhpParser/ParserAbstract.php:209
   ╵ /home/gregoire/dev/github.com/jolicode/elastically/vendor/nikic/php-parser/lib/PhpParser/ParserAbstract.php:159
   ╵ /home/gregoire/dev/github.com/jolicode/elastically/vendor/nikic/php-parser/lib/PhpParser/Parser/Multiple.php:51
   ╵ /home/gregoire/dev/github.com/jolicode/elastically/vendor/nikic/php-parser/lib/PhpParser/Parser/Multiple.php:32
   ╵ /home/gregoire/dev/github.com/jolicode/elastically/vendor/jane-php/json-schema/Generator/RuntimeGenerator.php:30
   ╵ /home/gregoire/dev/github.com/jolicode/elastically/vendor/jane-php/json-schema/Generator/ChainGenerator.php:28
   ╵ /home/gregoire/dev/github.com/jolicode/elastically/vendor/jane-php/json-schema/Console/Command/GenerateCommand.php:67
   ╵ /home/gregoire/dev/github.com/jolicode/elastically/tests/Jane/JaneTest.php:49
   ┴

Time: 00:00.052, Memory: 8.00 MB
```
  • Loading branch information
lyrixx authored Dec 16, 2022
1 parent f918cd0 commit 812815b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@
"symfony/messenger": "^4.4 || ^5.0 || ^6.0",
"symfony/phpunit-bridge": "^5.2 || ^6.0"
},
"conflict": {
"nikic/php-parser": "<4.7"
},
"autoload": {
"psr-4": {
"JoliCode\\Elastically\\": "./src"
Expand Down

0 comments on commit 812815b

Please sign in to comment.