Fix numerous bugs and errors

cogs/errorhandler.py

@@ -56,7 +56,7 @@ async def reinvoke_command(self, ctx: commands.Context):
             if ctx.guild is not None:
                 await queries.save_command_usage(ctx)
             return
-        except commands.CommandError as e:
+        except Exception as e:
             return await self.on_command_error(ctx, e)
 
     @staticmethod
@@ -70,7 +70,7 @@ async def send_embed(
         try:
             await ctx.send(
                 embed=discord.Embed(
-                    description=f"{emoji} {message}",
+                    description=f"{emoji} {message[:1500]}",
                     color=int(color, 16) if color else None,
                 ),
                 **kwargs,

cogs/kpop.py

@@ -289,9 +289,10 @@ async def send_group(self, ctx: commands.Context, group_id):
             """,
             group_id,
         )
-        content.add_field(
-            name="Members", value=", ".join(x[0] for x in member_list), inline=False
-        )
+        if member_list:
+            content.add_field(
+                name="Members", value=", ".join(x[0] for x in member_list), inline=False
+            )
 
         if image_url is None or (today - image_scrape_date.date).days > 30:
             search_term = f"{name} kpop group"

cogs/lastfm.py

@@ -1267,7 +1267,10 @@ async def colorchart(
         chart_nodes = []
 
         data = await self.get_all_albums(ctx.lfm.username)
-        albums = [LastFmImage.from_url(a["image"][-1]["#text"]) for a in data]
+        albums = filter(
+            lambda x: not x.is_missing(),
+            [LastFmImage.from_url(a["image"][-1]["#text"]) for a in data],
+        )
 
         to_fetch = []
         albumcolors = await self.bot.db.fetch(

modules/instagram.py

@@ -209,13 +209,18 @@ async def try_media(self, shortcode: str) -> list:
     async def get_post(self, shortcode: str):
         text = await self.request(f"{self.BASE_URL}/p/{shortcode}")
         soup = BeautifulSoup(text, "lxml")
-        metadata = {
-            "url": soup.find("a").attrs["href"],
-            "description": soup.find("meta", {"property": "og:description"}).attrs[
-                "content"
-            ],
-            "username": soup.find("meta", {"name": "twitter:title"}).attrs["content"],
-        }
+        try:
+            metadata = {
+                "url": soup.find("a").attrs["href"],
+                "description": soup.find("meta", {"property": "og:description"}).attrs[
+                    "content"
+                ],
+                "username": soup.find("meta", {"name": "twitter:title"}).attrs[
+                    "content"
+                ],
+            }
+        except AttributeError:
+            raise InstagramError("There was a problem fetching media for this post")
 
         media = await self.try_media(shortcode)
 

modules/media_embedders.py

@@ -395,6 +395,7 @@ async def create_message(
     ):
         instafix = InstaFix(self.bot.session)
         embedez = EmbedEz(self.bot.session)
+        error = None
 
         for provider in [instafix, embedez]:
             try:
@@ -427,10 +428,15 @@ async def create_message(
                 results = await asyncio.gather(*tasks)
             except (InstagramError, DownloadError) as e:
                 logger.warning(f"{provider} failed with {e}")
+                error = e
                 continue
             else:
+                error = None
                 break
 
+        if error is not None:
+            raise error
+
         if post.user.name:
             caption = f"{self.EMOJI} **{post.user.name}** `@{post.user.username}`"
         else:

modules/ui.py

@@ -130,7 +130,10 @@ async def run(self, context: discord.abc.Messageable):
     async def on_timeout(self):
         self.on_arrow_forward.disabled = True
         self.on_arrow_backward.disabled = True
-        await self.message.edit(view=self)
+        try:
+            await self.message.edit(view=self)
+        except discord.NotFound:
+            pass
         self.stop()
 
 

sql/init/1_kpop_schema.sql

@@ -15,7 +15,7 @@ CREATE TABLE IF NOT EXISTS kpop_group (
     orig_members INT,
     fanclub VARCHAR(64),
     active ENUM('Yes', 'No', 'Hiatus'),
-    image_url VARCHAR(256),
+    image_url VARCHAR(1024),
     image_scrape_date DATETIME,
     PRIMARY KEY (group_id)
 );
@@ -40,7 +40,7 @@ CREATE TABLE IF NOT EXISTS kpop_idol (
     position VARCHAR(64),
     instagram VARCHAR(64),
     twitter VARCHAR(64),
-    image_url VARCHAR(256),
+    image_url VARCHAR(1024),
     image_scrape_date DATETIME,
     UNIQUE(group_name, stage_name),
     PRIMARY KEY (idol_id)