-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] fix for extra text at last line of lyrics #215
base: master
Are you sure you want to change the base?
Conversation
Hi @gautamajay52, could you provide a couple of examples of lyrics returning those extra words? Thanks! |
I am not getting in all songs. I am integrating this with Spotify to get the current playing lyrics. Here is HTMl that I used to get when that text appear for me while testing. But on requesting again sometimes it doesn't appear. So it is random, but I have noticed it with a lot of songs. |
Here is another HTML Sir you can find the name of song in this html. edit: html of same song when I don't get that extra text. |
Sir ! Are you able to reproduce the error? |
I seem to be having this issue as well with songs such as "Say So" and "Kiss Me More" by Doja Cat. |
Hey, Have you tried this fix ? |
@gautamajay52 Yup seems to work fine so far! |
Actually, I was getting in almost all songs after doing multiple requests on the same song. |
There also appears to be extra header text prepended to the first line, too. When getting the div on line 137, this is what is outputted. Line one has the extra text "Mood Lyrics" in an Changing the pull request to this would fix both the original and this issue:
|
Some songs with translated lyrics also have some extra text at the beginning. I solved it with:
|
Most of the times the last line of lyrics has
EmbedShare Url:CopyEmbed:Copy
as extra words.