feat: handle tasks scheduled without a specific time #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannesjo
reviewed
Mar 9, 2025
| isMoveToBacklog: false, | ||
| }); | ||
| actions.push(schedule); | ||
| if (taskChanges.hasPlannedTime === false) { |
There was a problem hiding this comment.
hasPlannedTime never gets assigned anywhere, so it will never be false.
There was a problem hiding this comment.
PR Overview
This PR introduces the ability to schedule tasks without a specific time, so that such tasks will be planned for the day rather than being assigned a precise time. Key changes include:
- Adding a new boolean property "hasPlannedTime" to the task model.
- Modifying the short-syntax effect to dispatch a planTaskForDay action when a task is scheduled without a specific time.
- Adjusting task scheduling logic to differentiate between tasks with and without a specific planned time.
Reviewed Changes
| File | Description |
|---|---|
| src/app/features/tasks/store/short-syntax.effects.ts | Adds logic to check "hasPlannedTime" and dispatch actions accordingly. |
| src/app/features/tasks/task.model.ts | Introduces a new optional property "hasPlannedTime" to support the feature. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/app/features/tasks/store/short-syntax.effects.ts:138
- Ensure that the 'hasPlannedTime' property is explicitly set for tasks scheduled without a specific time. If left undefined, the condition may fail to trigger the intended planning logic, leading to incorrect task scheduling.
if (taskChanges.hasPlannedTime === false) {
src/app/features/tasks/task.model.ts:80
- [nitpick] Consider adding an inline comment or documentation in the task model to clearly describe the intended use of 'hasPlannedTime' for future maintainability.
hasPlannedTime?: boolean;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, when a user schedules a task with short syntax but doesn't give a specific time, the task will simply be planned for the day, without any time attached.
Under the hood, scheduled tasks without a specific time will dispatch
planTaskForDayaction. This is in contrast to scheduled tasks with a specific time which will triggerscheduleTaskaction.Visually, the task scheduled without time will be located at the top, underneath the relevant day column in the Planner view.
Issues Resolved
List any existing issues this PR resolves: #4049
Check List