Feat schedule picker popover #3796
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran this on my machine to play around. As mentioned in the original discussion: This might not work too well for desktop since it breaks the keyboard flow (makes only sense to to use the up and down keys imho). I can see this or something similar being added as via an additional button on mobile though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A rough custom implementation for popover. It's like dialog, but less intrusive. Developer can pass a custom component to it to render anything into this popover. It still needs further feedback in order to be complete.
Issues Resolved
Potentially resolves #3544 . Popover can be passed a calendar picker that allows uses to select date while adding new task.
Check List