Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollToHash get anchor by name #328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dolsup
Copy link

@dolsup dolsup commented Oct 22, 2020

<p><a name="user-content-debug.proto"></a></p>
<p align="right"><a href="#top">Top</a></p>
<h2>
<a id="user-content-debugproto" class="anchor" href="#debugproto" aria-hidden="true"><span aria-hidden="true" class="octicon octicon-link"></span></a>debug.proto</h2>

This is my exported index.html. ids of <a> tags including headers don't have .(period), but names of <a> tags in <p> above headers have original reference with ..

When a header had periods or anything IDK in their name, Its link is broken.

So I fixed it to use anchors with the name instead of anchors with id including header tag. I think this is why <p><a name="..."></a></p> is exists.

@dolsup
Copy link
Author

dolsup commented Oct 22, 2020

If you don't mind, could you put label hacktoberfest-accepted on this issue?

@dolsup
Copy link
Author

dolsup commented Oct 23, 2020

@joeyespo
Please check this out. This is a bug. a feature does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant