Fallback to diff_strings when assert_equal_* has no syntactic changes
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
commented
Jan 28, 2025
| @@ -47,6 +49,7 @@ def assert_equal_ruby(actual, expected) | |||
|
|
|||
| assert(actual == expected) do | |||
| diff = DIFFER.diff_ruby(actual, expected) | |||
| diff = DIFFER.diff_strings(actual, expected) if no_syntactic_changes?(diff) | |||
There was a problem hiding this comment.
If we'd use diff_objects here we'd also see the diff in whitespace, but I feel like it's not super nice to look at:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
assert_equal_rubythe diff wouldn't show when you have whitespace differences in the strings you are comparing.This pull request changes that behavior by falling back to
diff_stringswhenassert_equal_*has no syntactic changes.Before:
After: