Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Detox #84

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add Detox #84

wants to merge 4 commits into from

Conversation

rmccue
Copy link
Collaborator

@rmccue rmccue commented Jan 7, 2020

Adds Detox to run E2E tests. Requires a bit of setup, but works pretty well afterwards.

As a plus, we can use it to generate screenshots for the App Store :D

Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (5 errors, 20 warnings).

(12 notices occurred in your codebase, but were on files/lines not included in this PR.)

@rmccue
Copy link
Collaborator Author

rmccue commented Jan 7, 2020

Also, I haven't adjusted ESLint to add the Jest globals for Detox yet, so linting will fail for now.

@rmccue
Copy link
Collaborator Author

rmccue commented Jan 7, 2020

For some reason, --generate-screenshots manual isn't working for me. Once it does, we can finagle the generate-screenshots bit some more and pass an artifact directory manually to have a screenshots dir instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant