Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch a bunch of colours to standard iOS #71

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Switch a bunch of colours to standard iOS #71

wants to merge 2 commits into from

Conversation

rmccue
Copy link
Collaborator

@rmccue rmccue commented Dec 27, 2019

Uses the standard iOS colours. This is locked to light mode right now, and controlled by a static value in theme.ts; switching that changes to dark mode.

We can make this responsive using https://github.com/expo/react-native-appearance, but using something like DynamicStyleSheet from https://github.com/codemotionapps/react-native-dark-mode might be better - I essentially replicated that already and it worked alright.

Leaving as draft for now, because I didn't convert everything across yet, and not actually supporting dark mode is a bit annoying.

Copy link

@hm-linter hm-linter bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failed (2 errors, 2 warnings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant