Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aztec editor #34

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add Aztec editor #34

wants to merge 18 commits into from

Conversation

rmccue
Copy link
Collaborator

@rmccue rmccue commented May 15, 2017

See #4.

Early days, don't merge yet!

Currently fatal errors with any content with media in it, since we don't have a media delegate set. Seems like that's not in the Obj-C headers, so might need to switch to Swift for this...

@joehoyle
Copy link
Owner

Probably want to sync up with #35 when possible as that's on RN 0.44. Also, I am maintaining https://github.com/joehoyle/vienna/blob/master/upgrade-react-native.md as a log of how to set the project up a new, as basically when it comes to doing a RN upgrade it's basically a nuke and re-do the xcode project. Not ideal, but I think having this log is also good if we ever were to break the xcodeproject too.

@rmccue
Copy link
Collaborator Author

rmccue commented May 16, 2017

Looks like we need to switch to Swift, per wordpress-mobile/AztecEditor-iOS#475

Fine by me, but we'll need a small bridge for the RN macros.

@rmccue
Copy link
Collaborator Author

rmccue commented May 16, 2017

Editor's now in and firing events and such. Currently, typing too fast will cause problems as the UIView updates before React propagates the change back to the component. Typing slowly does work though, so people just need to be more thoughtful about what they're typing. #feature

Will think through best way to solve this, suspect I'll end up with a solution similar to FK.

@rmccue
Copy link
Collaborator Author

rmccue commented May 16, 2017

(Also still needs a proper toolbar, styling, etc etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants