get_response should not crash the connection (#142)

* get_response should not crash the connection `lists:keyfind` might return false if the id does not exist. For instance through multiple calls to `h2_connection:get_response`. * Use get_from_subset instead
joedevivo · Aug 13, 2020 · 560f2c7 · 560f2c7
1 parent d26a63f
commit 560f2c7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/h2_stream_set.erl b/src/h2_stream_set.erl
@@ -374,7 +374,7 @@ upsert_peer_subset(
   PeerSubset)
   when Id >= PeerSubset#peer_subset.lowest_stream_id,
        Id < PeerSubset#peer_subset.next_available_stream_id ->
-    OldStream = lists:keyfind(Id, 2, PeerSubset#peer_subset.active),
+    OldStream = get_from_subset(Id, PeerSubset),
     OldType = type(OldStream),
     ActiveDiff =
         case OldType of
@@ -393,7 +393,7 @@ upsert_peer_subset(
               lowest_stream_id=PeerSubset#peer_subset.next_available_stream_id,
               active_count=0,
               active=[]
-              };
+             };
         [NewLowestStream|_] ->
             NewLowest = stream_id(NewLowestStream),
             PeerSubset#peer_subset{
@@ -411,7 +411,7 @@ upsert_peer_subset(
   PeerSubset)
   when Id >= PeerSubset#peer_subset.lowest_stream_id,
        Id < PeerSubset#peer_subset.next_available_stream_id ->
-    OldStream = lists:keyfind(Id, 2, PeerSubset#peer_subset.active),
+    OldStream = get_from_subset(Id, PeerSubset),
     OldType = type(OldStream),
     ActiveDiff =
         case OldType of