Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always search for the full package name in existing IMPORT-FROMs #593

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tdrhq
Copy link
Contributor

@tdrhq tdrhq commented Apr 26, 2023

.. As opposed to just looking at prefixes. Previously, If you had an existing defpackage like this:

(defpakage :foo
(:import-from :bar/car
:find)))

And you imported bar::position, you'll end up with something ugly like this:

(defpackage :foo
(:import-from :bar
:position/car
:find))

.. As opposed to just looking at prefixes. Previously, If you had an existing defpackage like this:

(defpakage :foo
  (:import-from :bar/car
                :find)))

And you imported bar::position, you'll end up with something ugly like this:

(defpackage :foo
  (:import-from :bar
                :position/car
                :find))
@tdrhq
Copy link
Contributor Author

tdrhq commented Apr 26, 2023

This is a pretty common occurrence if you use single-package-per-file style, since packages have a hierarchical structure to them.

(PS. My next PR will be a bit more interesting, and you might like it. I have some patches locally where I can do C-c C-i on an symbol without the package specified, and it shows you a list of options in ido-mode to pick from. It greatly simplifies life, and I'll try sending another PR with that feature once this PR goes in.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant