Skip to content

Commit

Permalink
fix(build): don't force pnpm (#56)
Browse files Browse the repository at this point in the history
* chore: remove preinstall script from package.json

* build: update devDependencies in package.json to latest versions

* build: update Babel config and dependencies

* chore: Update type-check:watch script to use pnpm

* ci: update corepack usage in GitHub Actions workflow

* ci: update workflows to enable and use pnpm with corepack
  • Loading branch information
joaocarmo authored Jul 15, 2024
1 parent 8b022e5 commit 8e87c4f
Show file tree
Hide file tree
Showing 6 changed files with 4,500 additions and 3,664 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ jobs:
ref: 'main'

- name: Enable corepack
run: corepack enable
run: |
corepack enable pnpm
corepack use pnpm
- name: Use Node.js
uses: actions/setup-node@v4
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ jobs:
ref: 'main'

- name: Enable corepack
run: corepack enable
run: |
corepack enable pnpm
corepack use pnpm
- name: Use Node.js
uses: actions/setup-node@v4
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ jobs:
uses: actions/checkout@v4

- name: Enable corepack
run: corepack enable
run: |
corepack enable pnpm
corepack use pnpm
- name: Use Node.js
uses: actions/setup-node@v4
Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ module.exports = {
],
plugins: [
'@babel/plugin-transform-runtime',
'@babel/plugin-proposal-class-properties',
'@babel/plugin-transform-class-properties',
],
}
35 changes: 18 additions & 17 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,13 @@
"clean": "rm -rf ./dist/ ./node_modules/.cache/ *.vcf *.ics",
"lint:fix": "eslint . --fix",
"lint": "eslint .",
"preinstall": "npx only-allow pnpm",
"pretty:fix": "prettier --write .",
"pretty": "prettier --check .",
"test:functional": "(./test-functional/test-vcard.js | tee vcard.vcf) && (./test-functional/test-vcalendar.js 2>/dev/null | tee vcard.ics)",
"test:unit": "jest",
"test:web-build": "NODE_ENV=development webpack --mode development && open ./test-functional/test-build.html",
"test:web-export": "open ./test-functional/test-export.html",
"type-check:watch": "yarn type-check -- --watch",
"type-check:watch": "pnpm type-check --watch",
"type-check": "tsc --noEmit"
},
"repository": {
Expand All @@ -49,20 +48,19 @@
},
"homepage": "https://github.com/joaocarmo/vcard-creator#readme",
"devDependencies": {
"@babel/core": "^7.24.0",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-transform-runtime": "^7.24.0",
"@babel/preset-env": "^7.24.0",
"@babel/preset-typescript": "^7.23.3",
"@babel/runtime": "^7.24.0",
"@babel/core": "^7.24.8",
"@babel/plugin-transform-runtime": "^7.24.7",
"@babel/preset-env": "^7.24.8",
"@babel/preset-typescript": "^7.24.7",
"@babel/runtime": "^7.24.8",
"@types/jest": "^29.5.12",
"@types/node": "^20.11.25",
"@typescript-eslint/eslint-plugin": "^7.1.1",
"@typescript-eslint/parser": "^7.1.1",
"@types/node": "^20.14.10",
"@typescript-eslint/eslint-plugin": "^7.16.0",
"@typescript-eslint/parser": "^7.16.0",
"babel-core": "^6.26.3",
"babel-jest": "^29.7.0",
"babel-loader": "^9.1.3",
"core-js": "^3.36.0",
"core-js": "^3.37.1",
"eslint": "^8.57.0",
"eslint-config-airbnb-base": "^15.0.0",
"eslint-config-airbnb-typescript": "^18.0.0",
Expand All @@ -71,11 +69,14 @@
"eslint-plugin-jest": "^27.9.0",
"eslint-plugin-prettier": "^5.1.3",
"jest": "^29.7.0",
"jest-date-mock": "^1.0.8",
"prettier": "^3.2.5",
"ts-jest": "^29.1.2",
"typescript": "^5.4.2",
"webpack": "^5.90.3",
"jest-date-mock": "^1.0.10",
"prettier": "^3.3.3",
"ts-jest": "^29.2.2",
"typescript": "^5.5.3",
"webpack": "^5.93.0",
"webpack-cli": "^5.1.4"
},
"dependencies": {
"@babel/plugin-transform-class-properties": "^7.24.7"
}
}
Loading

0 comments on commit 8e87c4f

Please sign in to comment.