Setup projects for Java integration tests #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, build them on the CI
Filter ITs with tags so that no naming conventions are required
fixme: cargo test with features does not work
fixme: probably, convert to a child module so that dependency on jni.it is properly satisfied.
* Use two spaces * Follow naming conventions for groupId * Remove some unused plugins from pluginManagement
So that users do not have to download Maven manually.
dmitry-timofeev
requested review from
jrobsonchase,
alexander-irbis and
stanislav-tkach
and removed request for
jrobsonchase
| @REM ---------------------------------------------------------------------------- | ||
|
|
||
| @REM Begin all REM lines with '@' in case MAVEN_BATCH_ECHO is 'on' | ||
| @echo off |
There was a problem hiding this comment.
Perhaps it's worth to move @echo off to the beginning of the file and remove all "@" before REM, setlocal, etc?
There was a problem hiding this comment.
I actually have no idea what that means because this file is added as is by https://github.com/takari/maven-wrapper :-)
Do you think they must update anything?
There was a problem hiding this comment.
@ at the beginning of the line suppresses echo of the command in the line.
echo off - do the same for all following lines to not place @ in each line.
@echo off - typically the first line in almost all batch files since ancient DOS times.
There was a problem hiding this comment.
But if this is autogenerated file, it makes no sense to fix it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Setup the projects for Java integration tests.
Layout:
java-testsfor Java ITs using the native libraryjava-testlibwith implementations of native methods from ^java-benchmarksusingjava-testswith JMH setupjni— is the root for the libraryexample— is now included in the workspace to avoidjnirebuildsTravis now builds and tests (on top of
jni):examplejava-testsCloses #130
Definition of Done