Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig: Fix CI #423

Merged
merged 2 commits into from
Dec 12, 2023
Merged

zig: Fix CI #423

merged 2 commits into from
Dec 12, 2023

Conversation

kassane
Copy link
Contributor

@kassane kassane commented Dec 11, 2023

Fix Zig CI

@jmcnamara

TODO: 0.12.0 (break changes) unreleased yet!
@kassane

This comment has been minimized.

@jmcnamara
Copy link
Owner

These from paths are incorrect. They include D:\a\libxlsxwriter\libxlsxwriter twice.

install include/: error: unable to update file from 'D:\a\libxlsxwriter\libxlsxwriter\D:\a\libxlsxwriter\libxlsxwriter\include\xlsxwriter\hash_table.h' to 'D:\a\libxlsxwriter\libxlsxwriter\zig-out\include\xlsxwriter\hash_table.h': AccessDenied

@kassane
Copy link
Contributor Author

kassane commented Dec 12, 2023

These from paths are incorrect. They include D:\a\libxlsxwriter\libxlsxwriter twice.

install include/: error: unable to update file from 'D:\a\libxlsxwriter\libxlsxwriter\D:\a\libxlsxwriter\libxlsxwriter\include\xlsxwriter\hash_table.h' to 'D:\a\libxlsxwriter\libxlsxwriter\zig-out\include\xlsxwriter\hash_table.h': AccessDenied

This problem has fixed. 0f1e1b8

zig-out
├── bin
│   ├── anatomy
│   ├── array_formula
│   ├── autofilter
│   ├── background
│   ├── chart_area
│   ├── chart_column
│   ├── data_validate
│   ├── hello
│   ├── test_app
│   ├── test_app_xml_declaration
│   ├── test_chart
│   ├── test_chartsheet
│   ├── test_content_types
│   ├── test_content_types_write_default
│   ├── test_content_types_write_override
│   ├── test_core_xml_declaration
│   ├── test_custom_xml_declaration
│   ├── test_metadata_xml_declaration
│   ├── test_relationships
│   ├── test_relationships_xml_declaration
│   ├── test_shared_strings
│   ├── test_styles_write_border
│   ├── test_table01
│   ├── test_table02
│   ├── test_table03
│   ├── test_table04
│   ├── test_workbook
│   ├── test_xmlwriter
│   ├── watermark
│   └── worksheet_protection
├── include
│   ├── xlsxwriter
│   │   ├── app.h
│   │   ├── chart.h
│   │   ├── chartsheet.h
│   │   ├── comment.h
│   │   ├── common.h
│   │   ├── content_types.h
│   │   ├── core.h
│   │   ├── custom.h
│   │   ├── drawing.h
│   │   ├── format.h
│   │   ├── hash_table.h
│   │   ├── metadata.h
│   │   ├── packager.h
│   │   ├── relationships.h
│   │   ├── shared_strings.h
│   │   ├── styles.h
│   │   ├── table.h
│   │   ├── theme.h
│   │   ├── third_party
│   │   │   ├── emyg_dtoa.h
│   │   │   ├── ioapi.h
│   │   │   ├── md5.h
│   │   │   ├── queue.h
│   │   │   ├── tmpfileplus.h
│   │   │   ├── tree.h
│   │   │   └── zip.h
│   │   ├── utility.h
│   │   ├── vml.h
│   │   ├── workbook.h
│   │   ├── worksheet.h
│   │   └── xmlwriter.h
│   ├── xlsxwriter.h
│   ├── zconf.h
│   └── zlib.h
└── lib
    └── libxlsxwriter.a

@kassane
Copy link
Contributor Author

kassane commented Dec 12, 2023

Previously, zig had been pulling files copied from zig-out and re-reading the headers during the testBuild. (redundant path)

zig-out/include just makes headers available for users, while for building libxlsxwriter only needs the files in the current path.

@jmcnamara jmcnamara merged commit 9732c76 into jmcnamara:main Dec 12, 2023
40 checks passed
@kassane kassane deleted the zig_0.11.0 branch December 12, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants