Maintenance: update vendored minizip code to the version distributed with zlib v1.3 #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the vendored copy of
minizip
withinlibxlsxwriter
to the version distributed with version 1.3 ofzlib
with a fewlibxlsxwriter
customizations retained / re-applied.I have run the tests (
make test
) and valgrind checks (make test_valgrind
) on a system whereminizip
is not available as a system-provided library (to make sure that the vendored copy of the code was in use) and these passed.Abbreviated output from the tests is included below:
A small number of warnings were emitted by the valgrind checks; mostly string validation errors (length limits exceeded, unacceptable-null values, and placeholder-count mismatches), and it exited with code 0.
Resolves #419.