Use local web service for test #172
Conversation
jdietrich-tc
force-pushed
the
useLocalWebServiceForTest
branch
from
a68e4b0
to
ca32ae0
Compare
| @@ -43,17 +45,21 @@ func TestReadFile(t *testing.T) { | |||
|
|
|||
| func TestHTTPContent(t *testing.T) { | |||
| st := Stream{} | |||
| wg := &sync.WaitGroup{} | |||
There was a problem hiding this comment.
Hi, I'm struggeling to see why the WaitGroup is used. Could you elaborate a bit for me?
Thanks!
There was a problem hiding this comment.
It pauses the test until the http server is up and running. It communicates such when it calls the wait groups done function same then it passes back a handle to the server so that the test can shut the server done.
Without it, there is a race condition between starting the server and attempting to use it.
There was a problem hiding this comment.
But I don’t see any wg.Wait() that makes the test wait as you are describing. That's why a bit lost.
There was a problem hiding this comment.
To be honest, I'm not sure exactly how it works. I'm new to go (mmock is the first go code I've ever worked with) I found that I couldn't shut down the server once started, this hanging the tests. I found this, and it works.
https://stackoverflow.com/questions/39320025/how-to-stop-http-listenandserve
Instead of relying on connectivity of
https://golang.org/for testing http streaming, use a local web server, and call it. This makes the tests quicker and more reliable.