Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for management client passthrough #180

Merged
merged 8 commits into from
Feb 17, 2024
Merged

Add option for management client passthrough #180

merged 8 commits into from
Feb 17, 2024

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Feb 15, 2024

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke jkroepke added the ✨ enhancement New feature or request label Feb 15, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (3862426) 73.01% compared to head (0a83ea2) 73.08%.

Files Patch % Lines
internal/openvpn/passthrough.go 69.59% 27 Missing and 18 partials ⚠️
internal/openvpn/main.go 68.00% 5 Missing and 3 partials ⚠️
internal/openvpn/handler.go 64.28% 3 Missing and 2 partials ⚠️
pkg/testutils/main.go 90.69% 2 Missing and 2 partials ⚠️
cmd/daemon/root.go 50.00% 2 Missing ⚠️
internal/utils/lookup.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   73.01%   73.08%   +0.07%     
==========================================
  Files          48       49       +1     
  Lines        1890     2129     +239     
==========================================
+ Hits         1380     1556     +176     
- Misses        429      466      +37     
- Partials       81      107      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke jkroepke changed the title WIP passthrough Add option for management client passthrough Feb 17, 2024
@jkroepke jkroepke marked this pull request as ready for review February 17, 2024 23:14
@jkroepke jkroepke merged commit 16b50a6 into main Feb 17, 2024
7 of 8 checks passed
@jkroepke jkroepke deleted the passthrough branch February 17, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openvpn management interface passthrough (OpnSense compatibility)
1 participant