-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spring-webflux compatibility to handlebars-springmvc (#642) #647
base: master
Are you sure you want to change the base?
Conversation
* update spring version (3.1.1.RELEASE -> 5.0.7.RELEASE) * add spring-webflux * update Junit version (4.11 -> 4.12) * add handlebar spring reactive view and view resolver
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
============================================
- Coverage 87.33% 87.28% -0.05%
+ Complexity 841 833 -8
============================================
Files 78 78
Lines 3023 2989 -34
Branches 411 407 -4
============================================
- Hits 2640 2609 -31
+ Misses 261 260 -1
+ Partials 122 120 -2
Continue to review full report at Codecov.
|
Looks good with one question. Is Spring 5.x compatible with 3.x? I know 3.x is old (very old) but don't want to break existing integrations |
I created a Spring3 test project (https://github.com/shortstories/spring3-mvc-maven-xml-hello-world) and tried to run it. It works without problems. |
@jknack any chances this PR could be revitalized, so that Spring Webflux with Handlebars becomes available? |
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
=========================================
Coverage 87.28% 87.28%
Complexity 833 833
=========================================
Files 78 78
Lines 2989 2989
Branches 407 407
=========================================
Hits 2609 2609
Misses 260 260
Partials 120 120 Continue to review full report at Codecov.
|
3651d7f
to
96e61bd
Compare
HI! how i can help for push it to master? Because it's really actual for me) |
ReactiveHandlebarsView
ReactiveHandlebarsViewResolver